Export constant vectors as REE arrow schema #7327
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D50819081 |
pedroerp
force-pushed
the
export-D50819081
branch
from
88cc29e
to
a51c837
Compare
pedroerp
added a commit
to pedroerp/velox-1
that referenced
this pull request
Oct 31, 2023
Summary: This is the first PR to add support for constant vectors in Velox through the Arrow bridge. The PR maps the types and adds appropriate tests. The next one will map the actual data. Differential Revision: D50819081
|
This pull request was exported from Phabricator. Differential Revision: D50819081 |
pedroerp
added a commit
to pedroerp/velox-1
that referenced
this pull request
Oct 31, 2023
Summary: This is the first PR to add support for constant vectors in Velox through the Arrow bridge. The PR maps the types and adds appropriate tests. The next one will map the actual data. Differential Revision: D50819081
pedroerp
force-pushed
the
export-D50819081
branch
from
a51c837
to
ba07fe4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50819081 |
majetideepak
requested changes
Nov 1, 2023
| @@ -91,6 +96,59 @@ class ArrowBridgeSchemaExportTest : public testing::Test { | |||
| } | |||
| } | |||
|
|
|||
| void testConstant(const TypePtr& type, const char* arrowFormat) { | |||
| ArrowSchema arrowSchema; | |||
| const bool isScalar = type->size() == 0; | |||
There was a problem hiding this comment.
nit const bool isScalar = (type->size() == 0);
| @@ -644,6 +663,26 @@ void exportToArrow(const VectorPtr& vec, ArrowSchema& arrowSchema) { | |||
| arrowSchema.dictionary = bridgeHolder->dictionary.get(); | |||
| exportToArrow(vec->valueVector(), *arrowSchema.dictionary); | |||
|
|
|||
| } else if (vec->encoding() == VectorEncoding::Simple::CONSTANT) { | |||
There was a problem hiding this comment.
It helps to add a link to the spec https://arrow.apache.org/docs/format/Columnar.html#run-end-encoded-layout
majetideepak
approved these changes
Nov 1, 2023
pedroerp
force-pushed
the
export-D50819081
branch
from
ba07fe4
to
444a1ef
Compare
pedroerp
added a commit
to pedroerp/velox-1
that referenced
this pull request
Nov 1, 2023
Summary: This is the first PR to add support for constant vectors in Velox through the Arrow bridge. The PR maps the types and adds appropriate tests. The next one will map the actual data. Reviewed By: mbasmanova Differential Revision: D50819081
Summary: This is the first PR to add support for constant vectors in Velox through the Arrow bridge. The PR maps the types and adds appropriate tests. The next one will map the actual data. Reviewed By: mbasmanova Differential Revision: D50819081
|
This pull request was exported from Phabricator. Differential Revision: D50819081 |
pedroerp
force-pushed
the
export-D50819081
branch
from
444a1ef
to
02eb286
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50819081 |
|
Thanks @majetideepak , comments addressed. |
|
This pull request has been merged in d8d362c. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is the first PR to add support for constant vectors in Velox
through the Arrow bridge. The PR maps the types and adds appropriate tests. The
next one will map the actual data.
Differential Revision: D50819081