Optimize remaining filter evaluation #7433
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51039406 |
Yuhta
added a commit
to Yuhta/velox
that referenced
this pull request
Nov 6, 2023
Summary: Currently when we have a remaining filter separated by ANDs and same field is multi-referenced from different clauses, we eagerly materialize that field. If there is a very selective condition in the AND clauses, we lose the opportunity to avoid reading unneeded rows using that condition on the mutli-referenced field. Since AND always reduces the selectivity, there is no need to eagerly evaluate the multi-referenced fields. It gives 2.6x performance gain in some queries by evaluating the field lazily. Differential Revision: D51039406
Yuhta
force-pushed
the
export-D51039406
branch
from
d354626
to
925c1c7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51039406 |
Yuhta
added a commit
to Yuhta/velox
that referenced
this pull request
Nov 6, 2023
Summary: Currently when we have a remaining filter separated by ANDs and same field is multi-referenced from different clauses, we eagerly materialize that field. If there is a very selective condition in the AND clauses, we lose the opportunity to avoid reading unneeded rows using that condition on the mutli-referenced field. Since AND always reduces the selectivity, there is no need to eagerly evaluate the multi-referenced fields. It gives 2.6x performance gain in some queries by evaluating the field lazily. Differential Revision: D51039406
Yuhta
force-pushed
the
export-D51039406
branch
from
925c1c7
to
b2009c1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51039406 |
Yuhta
added a commit
to Yuhta/velox
that referenced
this pull request
Nov 6, 2023
Summary: Currently when we have a remaining filter separated by ANDs and same field is multi-referenced from different clauses, we eagerly materialize that field. If there is a very selective condition in the AND clauses, we lose the opportunity to avoid reading unneeded rows using that condition on the mutli-referenced field. Since AND always reduces the selectivity, there is no need to eagerly evaluate the multi-referenced fields. It gives 2.6x performance gain in some queries by evaluating the field lazily. Reviewed By: laithsakka Differential Revision: D51039406
Yuhta
force-pushed
the
export-D51039406
branch
from
b2009c1
to
7b16729
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51039406 |
Yuhta
added a commit
to Yuhta/velox
that referenced
this pull request
Nov 6, 2023
Summary: Currently when we have a remaining filter separated by ANDs and same field is multi-referenced from different clauses, we eagerly materialize that field. If there is a very selective condition in the AND clauses, we lose the opportunity to avoid reading unneeded rows using that condition on the mutli-referenced field. Since AND always reduces the selectivity, there is no need to eagerly evaluate the multi-referenced fields. It gives 2.6x performance gain in some queries by evaluating the field lazily. Reviewed By: laithsakka Differential Revision: D51039406
Yuhta
force-pushed
the
export-D51039406
branch
from
7b16729
to
2a2ed7e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51039406 |
Summary: Currently when we have a remaining filter separated by ANDs and same field is multi-referenced from different clauses, we eagerly materialize that field. If there is a very selective condition in the AND clauses, we lose the opportunity to avoid reading unneeded rows using that condition on the mutli-referenced field. Since AND always reduces the selectivity, there is no need to eagerly evaluate the multi-referenced fields. It gives 2.6x performance gain in some queries by evaluating the field lazily. Reviewed By: laithsakka Differential Revision: D51039406
Yuhta
force-pushed
the
export-D51039406
branch
from
2a2ed7e
to
1c0742a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51039406 |
|
This pull request has been merged in fc8a69f. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Currently when we have a remaining filter separated by ANDs and same field is multi-referenced from different clauses, we eagerly materialize that field. If there is a very selective condition in the AND clauses, we lose the opportunity to avoid reading unneeded rows using that condition on the mutli-referenced field.
Since AND always reduces the selectivity, there is no need to eagerly evaluate the multi-referenced fields. It gives 2.6x performance gain in some queries by evaluating the field lazily.
Differential Revision: D51039406