Fix toMillis() should work for all presto timestamps #7506
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51177715 |
laithsakka
changed the title
laithsakka
added a commit
to laithsakka/velox
that referenced
this pull request
Nov 9, 2023
…#7506) Summary: Presto timestamps are in the range TimeStamp::minMillis() to TimeStamp::maxMillis(). moreover minMillis has a comment: ``` // The minimum Timestamp that toMillis() method will not overflow. // Used to calculate the minimum value of the Presto timestamp. ``` Before this diff TimeStamp::minMillis().toMillis throws because the computation overflows. However in that case we multiply negative number then add positive number so the final result still fits in int64_t. It is important the toMillis does not throw when it should not, since it is used in functions like inPredicate() and other functions that do not expect it to throw for some values. Throwing will show up as incorrect results compared to presto. This diff fixes that . I wonder if we shall throw a runtime error in toMillis() instead. found while investigating facebookincubator#7161 Differential Revision: D51177715
laithsakka
force-pushed
the
export-D51177715
branch
from
b00cffb
to
36eac2b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51177715 |
kagamiori
approved these changes
Nov 10, 2023
| (int64_t)(nanos_ / 1'000'000)); | ||
| } catch (const std::exception& e) { | ||
| __int128_t result = | ||
| (__int128_t)seconds_ * 1'000 + (int64_t)(nanos_ / 1'000'000); |
There was a problem hiding this comment.
nit: Use int128_t defined in Type.h.
laithsakka
added a commit
to laithsakka/velox
that referenced
this pull request
Nov 10, 2023
…#7506) Summary: Presto timestamps are in the range TimeStamp::minMillis() to TimeStamp::maxMillis(). moreover minMillis has a comment: ``` // The minimum Timestamp that toMillis() method will not overflow. // Used to calculate the minimum value of the Presto timestamp. ``` Before this diff TimeStamp::minMillis().toMillis throws because the computation overflows. However in that case we multiply negative number then add positive number so the final result still fits in int64_t. It is important the toMillis does not throw when it should not, since it is used in functions like inPredicate() and other functions that do not expect it to throw for some values. Throwing will show up as incorrect results compared to presto. This diff fixes that . I wonder if we shall throw a runtime error in toMillis() instead. found while investigating facebookincubator#7161 Reviewed By: kagamiori Differential Revision: D51177715
laithsakka
force-pushed
the
export-D51177715
branch
from
36eac2b
to
253a78f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51177715 |
…#7506) Summary: Presto timestamps are in the range TimeStamp::minMillis() to TimeStamp::maxMillis(). moreover minMillis has a comment: ``` // The minimum Timestamp that toMillis() method will not overflow. // Used to calculate the minimum value of the Presto timestamp. ``` Before this diff TimeStamp::minMillis().toMillis throws because the computation overflows. However in that case we multiply negative number then add positive number so the final result still fits in int64_t. It is important the toMillis does not throw when it should not, since it is used in functions like inPredicate() and other functions that do not expect it to throw for some values. Throwing will show up as incorrect results compared to presto. This diff fixes that . I wonder if we shall throw a runtime error in toMillis() instead. found while investigating facebookincubator#7161 Reviewed By: kagamiori Differential Revision: D51177715
laithsakka
force-pushed
the
export-D51177715
branch
from
253a78f
to
69fc2cb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51177715 |
|
This pull request has been merged in 671e126. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Presto timestamps are in the range TimeStamp::minMillis() to TimeStamp::maxMillis().
moreover minMillis has a comment:
Before this diff TimeStamp::minMillis().toMillis throws because the computation
overflows. However in that case we multiply negative number then add positive number
so the final result still fits in int64_t.
It is important the toMillis does not throw when it should not, since it is used in
functions like inPredicate() and other functions that do not expect it to throw
for some values. Throwing will show up as incorrect results compared to presto.
This diff fixes that .
I wonder if we shall throw a runtime error in toMillis() instead.
found while investigating #7161
Differential Revision: D51177715