Move sapling_backingstore_get_tree_batch to cxx_bridge #7595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51321500 |
jdelliot
pushed a commit
to jdelliot/mvfst
that referenced
this pull request
Nov 15, 2023
Summary: X-link: facebook/fboss#167 X-link: facebookincubator/velox#7595 cxx.rs provides a more ergonomic and opinionated interop layer between Rust and C++ that we would like to leverage for future API chages. This moves sapling_backingstore_get_tree_batch from the existing cbindgen implemenation to the new cxxbridge. Reviewed By: xavierd Differential Revision: D51321500
jdelliot
pushed a commit
to jdelliot/proxygen
that referenced
this pull request
Nov 15, 2023
Summary: X-link: facebook/folly#2098 X-link: facebook/fboss#167 X-link: facebookincubator/velox#7595 cxx.rs provides a more ergonomic and opinionated interop layer between Rust and C++ that we would like to leverage for future API chages. This moves sapling_backingstore_get_tree_batch from the existing cbindgen implemenation to the new cxxbridge. Reviewed By: xavierd Differential Revision: D51321500
jdelliot
pushed a commit
to jdelliot/wangle
that referenced
this pull request
Nov 15, 2023
Summary: X-link: facebook/mvfst#323 X-link: facebook/hhvm#9413 X-link: facebook/folly#2098 X-link: facebook/fboss#167 X-link: facebookincubator/velox#7595 cxx.rs provides a more ergonomic and opinionated interop layer between Rust and C++ that we would like to leverage for future API chages. This moves sapling_backingstore_get_tree_batch from the existing cbindgen implemenation to the new cxxbridge. Reviewed By: xavierd Differential Revision: D51321500
This was referenced Nov 15, 2023
jdelliot
pushed a commit
to jdelliot/sapling
that referenced
this pull request
Nov 15, 2023
Summary: X-link: facebook/hhvm#9413 X-link: facebook/folly#2098 X-link: facebook/fboss#167 X-link: facebookincubator/velox#7595 cxx.rs provides a more ergonomic and opinionated interop layer between Rust and C++ that we would like to leverage for future API chages. This moves sapling_backingstore_get_tree_batch from the existing cbindgen implemenation to the new cxxbridge. Reviewed By: xavierd Differential Revision: D51321500
jdelliot
pushed a commit
to jdelliot/watchman
that referenced
this pull request
Nov 15, 2023
Summary: X-link: facebook/mvfst#323 X-link: facebook/hhvm#9413 X-link: facebook/folly#2098 X-link: facebook/fboss#167 X-link: facebookincubator/velox#7595 cxx.rs provides a more ergonomic and opinionated interop layer between Rust and C++ that we would like to leverage for future API chages. This moves sapling_backingstore_get_tree_batch from the existing cbindgen implemenation to the new cxxbridge. Reviewed By: xavierd Differential Revision: D51321500
jdelliot
pushed a commit
to jdelliot/edencommon
that referenced
this pull request
Nov 15, 2023
Summary: X-link: facebook/proxygen#474 X-link: facebook/mvfst#323 X-link: facebook/hhvm#9413 X-link: facebook/folly#2098 X-link: facebook/fboss#167 X-link: facebookincubator/velox#7595 cxx.rs provides a more ergonomic and opinionated interop layer between Rust and C++ that we would like to leverage for future API chages. This moves sapling_backingstore_get_tree_batch from the existing cbindgen implemenation to the new cxxbridge. Reviewed By: xavierd Differential Revision: D51321500
jdelliot
pushed a commit
to jdelliot/rust-shed
that referenced
this pull request
Nov 15, 2023
Summary: X-link: facebook/proxygen#474 X-link: facebook/mvfst#323 X-link: facebook/hhvm#9413 X-link: facebook/folly#2098 X-link: facebook/fboss#167 X-link: facebookincubator/velox#7595 cxx.rs provides a more ergonomic and opinionated interop layer between Rust and C++ that we would like to leverage for future API chages. This moves sapling_backingstore_get_tree_batch from the existing cbindgen implemenation to the new cxxbridge. Reviewed By: xavierd Differential Revision: D51321500
jdelliot
pushed a commit
to jdelliot/fizz
that referenced
this pull request
Nov 15, 2023
Summary: X-link: facebookexperimental/rust-shed#46 X-link: facebook/watchman#1174 X-link: facebook/wangle#223 X-link: facebook/proxygen#474 X-link: facebook/mvfst#323 X-link: facebook/hhvm#9413 X-link: facebook/folly#2098 X-link: facebook/fboss#167 X-link: facebookincubator/velox#7595 cxx.rs provides a more ergonomic and opinionated interop layer between Rust and C++ that we would like to leverage for future API chages. This moves sapling_backingstore_get_tree_batch from the existing cbindgen implemenation to the new cxxbridge. Reviewed By: xavierd Differential Revision: D51321500
jdelliot
pushed a commit
to jdelliot/hsthrift
that referenced
this pull request
Nov 15, 2023
Summary: X-link: facebookexperimental/rust-shed#46 X-link: facebook/watchman#1174 X-link: facebook/wangle#223 X-link: facebook/proxygen#474 X-link: facebook/mvfst#323 X-link: facebook/hhvm#9413 X-link: facebook/folly#2098 X-link: facebook/fboss#167 X-link: facebookincubator/velox#7595 cxx.rs provides a more ergonomic and opinionated interop layer between Rust and C++ that we would like to leverage for future API chages. This moves sapling_backingstore_get_tree_batch from the existing cbindgen implemenation to the new cxxbridge. Reviewed By: xavierd Differential Revision: D51321500
jdelliot
pushed a commit
to jdelliot/katran
that referenced
this pull request
Nov 15, 2023
Summary: X-link: facebookexperimental/rust-shed#46 X-link: facebook/watchman#1174 X-link: facebook/wangle#223 X-link: facebook/proxygen#474 X-link: facebook/mvfst#323 X-link: facebook/hhvm#9413 X-link: facebook/folly#2098 X-link: facebook/fboss#167 X-link: facebookincubator/velox#7595 cxx.rs provides a more ergonomic and opinionated interop layer between Rust and C++ that we would like to leverage for future API chages. This moves sapling_backingstore_get_tree_batch from the existing cbindgen implemenation to the new cxxbridge. Reviewed By: xavierd Differential Revision: D51321500
Summary: cxx.rs provides a more ergonomic and opinionated interop layer between Rust and C++ that we would like to leverage for future API chages. This moves sapling_backingstore_get_tree_batch from the existing cbindgen implemenation to the new cxxbridge. Reviewed By: xavierd Differential Revision: D51321500
|
This pull request was exported from Phabricator. Differential Revision: D51321500 |
|
This pull request was exported from Phabricator. Differential Revision: D51321500 |
2 similar comments
|
This pull request was exported from Phabricator. Differential Revision: D51321500 |
|
This pull request was exported from Phabricator. Differential Revision: D51321500 |
|
This pull request was exported from Phabricator. Differential Revision: D51321500 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D51321500 |
jdelliot
pushed a commit
to jdelliot/velox
that referenced
this pull request
Nov 29, 2023
…ator#7595) Summary: X-link: facebookincubator/katran#209 X-link: facebook/folly#2098 X-link: facebook/fbthrift#588 cxx.rs provides a more ergonomic and opinionated interop layer between Rust and C++ that we would like to leverage for future API chages. This moves sapling_backingstore_get_tree_batch from the existing cbindgen implemenation to the new cxxbridge. Reviewed By: xavierd Differential Revision: D51321500
|
This pull request was exported from Phabricator. Differential Revision: D51321500 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D51321500 |
jdelliot
added a commit
to jdelliot/velox
that referenced
this pull request
Nov 29, 2023
…ator#7595) Summary: Pull Request resolved: facebookincubator#7595 X-link: facebookincubator/katran#209 X-link: facebook/folly#2098 X-link: facebook/fbthrift#588 cxx.rs provides a more ergonomic and opinionated interop layer between Rust and C++ that we would like to leverage for future API chages. This moves sapling_backingstore_get_tree_batch from the existing cbindgen implemenation to the new cxxbridge. Reviewed By: xavierd Differential Revision: D51321500 fbshipit-source-id: c5c21128ce4bbc7b5c71d8ef56ae6fa0012ea2ae
|
This pull request was exported from Phabricator. Differential Revision: D51321500 |
jdelliot
added a commit
to jdelliot/velox
that referenced
this pull request
Nov 29, 2023
…ator#7595) Summary: Pull Request resolved: facebookincubator#7595 X-link: facebookincubator/katran#209 X-link: facebook/folly#2098 X-link: facebook/fbthrift#588 cxx.rs provides a more ergonomic and opinionated interop layer between Rust and C++ that we would like to leverage for future API chages. This moves sapling_backingstore_get_tree_batch from the existing cbindgen implemenation to the new cxxbridge. Reviewed By: xavierd Differential Revision: D51321500 fbshipit-source-id: ef0a197632671d76de9bc28a6b0ddfd3d7bb4c8d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
cxx.rs provides a more ergonomic and opinionated interop layer between Rust and C++ that we would like to leverage for future API chages.
This moves sapling_backingstore_get_tree_batch from the existing cbindgen implemenation to the new cxxbridge.
Reviewed By: xavierd
Differential Revision: D51321500