Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unix_date Spark function #8725

Closed
wants to merge 10 commits into from
Closed

Add unix_date Spark function #8725

wants to merge 10 commits into from

Conversation

acvictor
Copy link
Contributor

Returns the number of days since 1970-01-01.

Addresses #8720

@netlify Netlify
Copy link

netlify bot commented Feb 12, 2024 •
edited
Loading

✅ Deploy Preview for meta-velox ready!

Name Link
🔨 Latest commit 55d081a
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/65e19f9271804b000885fdea
😎 Deploy Preview https://deploy-preview-8725--meta-velox.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 12, 2024
@acvictor
Copy link
Contributor Author

@PHILO-HE @rui-mo please review, thank you!

@PHILO-HE
Copy link
Contributor

PHILO-HE commented Feb 12, 2024 •
edited
Loading

This pr looks good to me. Maybe, better to use "unix_date" in the title to align with Spark's function name.
@mbasmanova, do you have any comment?

@acvictor acvictor changed the title Add unixdate Spark function Add unix_date Spark function Feb 12, 2024
@acvictor
Copy link
Contributor Author

@mbasmanova can you please take a look at this PR?

@acvictor
Copy link
Contributor Author

acvictor commented Mar 1, 2024

@mbasmanova can you review again please? Thanks!

mbasmanova
mbasmanova approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@mbasmanova mbasmanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@facebook-github-bot
Copy link
Contributor

@mbasmanova has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@mbasmanova merged this pull request in f2a4238.

@acvictor
Copy link
Contributor Author

acvictor commented Mar 1, 2024

Looks good to me.

Thank you for the review!

@acvictor acvictor deleted the acvictor/unixdate branch April 10, 2024 14:14
@PHILO-HE PHILO-HE mentioned this pull request May 17, 2024
Open
99 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yuhta Yuhta Yuhta approved these changes

@mbasmanova mbasmanova mbasmanova approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@acvictor @PHILO-HE @facebook-github-bot @Yuhta @mbasmanova