Remove unused exception parameter from velox/common/base/tests/AsyncSourceTest.cpp #9910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D57636920 |
✅ Deploy Preview for meta-velox canceled.
|
…ourceTest.cpp (facebookincubator#9910) Summary: `-Wunused-exception-parameter` has identified an unused exception parameter. This diff removes it. This: ``` try { ... } catch (exception& e) { // no use of e } ``` should instead be written as ``` } catch (exception&) { ``` If the code compiles, this is safe to land. Reviewed By: palmje, mbasmanova Differential Revision: D57636920
r-barnes
force-pushed
the
export-D57636920
branch
from
0c03674
to
ee4512b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57636920 |
|
This pull request has been merged in 5eeb3f9. |
|
Conbench analyzed the 1 benchmark run on commit There was 1 benchmark result indicating a performance regression:
The full Conbench report has more details. |
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
…ourceTest.cpp (facebookincubator#9910) Summary: Pull Request resolved: facebookincubator#9910 `-Wunused-exception-parameter` has identified an unused exception parameter. This diff removes it. This: ``` try { ... } catch (exception& e) { // no use of e } ``` should instead be written as ``` } catch (exception&) { ``` If the code compiles, this is safe to land. Reviewed By: palmje, mbasmanova Differential Revision: D57636920 fbshipit-source-id: 8861d0269a24d57b421f03c111f09de5fefc3422
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
…ourceTest.cpp (facebookincubator#9910) Summary: Pull Request resolved: facebookincubator#9910 `-Wunused-exception-parameter` has identified an unused exception parameter. This diff removes it. This: ``` try { ... } catch (exception& e) { // no use of e } ``` should instead be written as ``` } catch (exception&) { ``` If the code compiles, this is safe to land. Reviewed By: palmje, mbasmanova Differential Revision: D57636920 fbshipit-source-id: 8861d0269a24d57b421f03c111f09de5fefc3422
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
-Wunused-exception-parameterhas identified an unused exception parameter. This diff removes it.This:
should instead be written as
If the code compiles, this is safe to land.
Reviewed By: palmje
Differential Revision: D57636920