Conversation
Hi @wrigby! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
D31507009 moved the logging macros to a different header, but this header wasn't added to CMakeLists. This diff fixes the CMake build. Tested with: ``` mkdir build; cd build; cmake ..; make ```
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Woops. I didn't even notice that this was already fixed by #48 . I guess I'll leave this up here and let @cooperlees decide which one to merge 🤪 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks. Lets try and get this merged.
@cooperlees has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@cooperlees Heads up - if you haven't landed this yet, I think this diff doesn't actually work for GCC builds. I only tested on macOS / Clang last night, but while trying to get the CircleCI config fixed today, linking the tests failed. #48 builds cleanly, though. Full failing build output (on an Ubuntu CircleCI image):
|
Yeah, sorry mate. This is the same as 48. Hopefully someone (internally) approves those today and we can merge. And then this can be closed. |
D31507009 moved the logging macros to a different header, but this header
wasn't added to CMakeLists. This diff fixes the CMake build.
Tested with:
Fixes #49