-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerfile not building vrs CLI? #30
Comments
For more context, I ran |
Hello @Andrew12Liu we recently changed the way dependencies are managed and now VRS is used directly as a module, not a precompiled library (as a consequence, we are not building by default the tools). If you are in the docker aria-data-tools you can build the binary by triggering Comment line 32/33 here https://github.com/facebookresearch/Aria_data_tools/blob/main/src/CMakeLists.txt#L32 Then run
|
thanks for the rapid response time @SeaOtocinclus , presumably if i want my docker image to have the vrs tools, ill just add
to the dockerfile |
Thank you for your feedback, feel free to contribute its addition back to the repository ;-) |
@SeaOtocinclus thanks for the help, that seemed to do the trick, all i had to do was make install it afterwards. happy to add this in a PR, I currently have it in a fork's PR. |
Great, happy to see we were able to found a quick solution! |
Do you want to close the issue, or keep it open until we have VRS compiled in the docker image? |
@SeaOtocinclus im okay with closing it, as we found the resolution. I am indifferent on having VRS compiled in the docker image. Perhaps other users may not need it. Adding a note in the build readme or documentation could clarify for future users. |
Hi Aria team,
I was running the dockerfile to build aria-data-tools. I noticed that the build directory did not build the VRS CLI. More specifically, I noticed the build subdirectory for vrs under the third-party directory was missing the tools build directory associated with the CLI from my understanding. My logic could be wrong so would appreciate any help on this. Thank you!
The text was updated successfully, but these errors were encountered: