Add error messages for easier debugging #151
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D32604698 |
Summary: Pull Request resolved: facebookresearch#151 The `False is not True` error that occurs when the expected media/metadata doesn't match is hard to parse for our users. Let's add more detailed messaging such that it's easier to debug augmentations! This change doesn't apply to the text library since those tests don't have a unified base test etc :) Reviewed By: zpapakipos Differential Revision: D32604698 fbshipit-source-id: 5f6e8175903046b94c7b87a1e1eeb849eaa3b580
zpapakipos
force-pushed
the
export-D32604698
branch
from
691f06c
to
0d062bf
Compare
|
This pull request was exported from Phabricator. Differential Revision: D32604698 |
|
This pull request has been merged in 614b28c. |
Adib234
added a commit
to Adib234/AugLy
that referenced
this pull request
Dec 7, 2021
…-merge-video-audio * 'main' of https://github.com/Adib234/AugLy: Update resize() to be on par with torchvision speed (facebookresearch#144) Change local image paths to links (facebookresearch#162) Text Augmentation Optimizations (facebookresearch#147) chore(typo) (facebookresearch#154) Downloads badge (facebookresearch#158) Add error messages for easier debugging (facebookresearch#151)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The
False is not Trueerror that occurs when the expected media/metadata doesn't match is hard to parse for our users. Let's add more detailed messaging such that it's easier to debug augmentations!This change doesn't apply to the text library since those tests don't have a unified base test etc :)
Differential Revision: D32604698