[Text] Fix return types #191
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@zpapakipos has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@zpapakipos has updated the pull request. You must reimport the pull request before landing. |
|
@zpapakipos has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: ## Related Issue Fixes facebookresearch#189 - [x] I have read CONTRIBUTING.md to understand how to contribute to this repository :) Fixing the text augmentations' return types -- the output type is the same type as the input, which can be either a `str` or a `List[str]`. ## Unit Tests See the `test_python` workflow. Pull Request resolved: facebookresearch#191 Differential Revision: D34340331 Pulled By: zpapakipos fbshipit-source-id: 87b6b2fe6f8e97bcc534b98326f0079153c49858
zpapakipos
force-pushed
the
text_return_types
branch
from
7a6ae16
to
f6c5b79
Compare
|
This pull request was exported from Phabricator. Differential Revision: D34340331 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #189
Summary
Fixing the text augmentations' return types -- the output type is the same type as the input, which can be either a
stror aList[str].Unit Tests
See the
test_pythonworkflow.