Remove local_rank parameter from ClassyTask #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: That is not being used AFAICT and it's polluting the API. Differential Revision: D17547887 fbshipit-source-id: 1b9566a710aa45145850e933c5a57cf352d4fcd5
facebook-github-bot
added
the
CLA Signed
|
This pull request has been merged in a829687. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 26, 2019
Summary: Pull Request resolved: fairinternal/ClassyVision#15 Pull Request resolved: #118 In my dataset refactor, I forgot to pass the epoch to the sampler so it was using the same shuffle for every epoch. This diff passes epoch to the _get_sampler function. Reviewed By: mannatsingh Differential Revision: D18137655 fbshipit-source-id: cb7492740a2c9ab5fad7c30f266893e769cac328
vaibhava0
pushed a commit
to vaibhava0/ClassyVision
that referenced
this pull request
Jan 19, 2021
Summary: Pull Request resolved: fairinternal/ClassyVision#15 Pull Request resolved: facebookresearch#118 In my dataset refactor, I forgot to pass the epoch to the sampler so it was using the same shuffle for every epoch. This diff passes epoch to the _get_sampler function. Reviewed By: mannatsingh Differential Revision: D18137655 fbshipit-source-id: cb7492740a2c9ab5fad7c30f266893e769cac328
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: That is not being used AFAICT and it's polluting the API.
Differential Revision: D17547887