Switch transforms to .from_config idiom #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Summary: Pull Request resolved: facebookresearch/ClassyVision#18 I was originally against a ClassyTransform abstraction, but I've come around. All other Classy things implement a from_config method, so we need a ClassyTransform as well. That gives us the flexibility of implementing transforms where the dictionary can't be mapped directly to arguments in the constructor. Differential Revision: D17578366 fbshipit-source-id: ef339ae297b362057ae4143557381d8a931ccd0b
vreis
force-pushed
the
export-D17578366
branch
from
4dc0300
to
3fd32f8
Compare
|
This pull request has been merged in 48a8f25. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 28, 2019
Summary: Pull Request resolved: fairinternal/ClassyVision#18 Pull Request resolved: #128 Meter state dict abstraction serves almost same purpose as get_classy_state / set_classy_state. Cleaning this up before OSS by removing the meter_state_dict calls and moving all logic to get / set classy state calls. Reviewed By: mannatsingh Differential Revision: D18162805 fbshipit-source-id: d217eafc85e06b4081288227b2b1cc7a5d9d863b
vaibhava0
pushed a commit
to vaibhava0/ClassyVision
that referenced
this pull request
Jan 19, 2021
Summary: Pull Request resolved: fairinternal/ClassyVision#18 Pull Request resolved: facebookresearch#128 Meter state dict abstraction serves almost same purpose as get_classy_state / set_classy_state. Cleaning this up before OSS by removing the meter_state_dict calls and moving all logic to get / set classy state calls. Reviewed By: mannatsingh Differential Revision: D18162805 fbshipit-source-id: d217eafc85e06b4081288227b2b1cc7a5d9d863b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I was originally against a ClassyTransform abstraction, but I've come around.
All other Classy things implement a from_config method, so we need a
ClassyTransform as well. That gives us the flexibility of implementing
transforms where the dictionary can't be mapped directly to arguments in the
constructor.
Differential Revision: D17578366