Make classy_train.py easier to use #184
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D18364662 |
vreis
force-pushed
the
export-D18364662
branch
from
05ed1fd
to
5cebef7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D18364662 |
vreis
force-pushed
the
export-D18364662
branch
from
5cebef7
to
3d55ffb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D18364662 |
vreis
force-pushed
the
export-D18364662
branch
from
3d55ffb
to
c2cb47a
Compare
Summary: Pull Request resolved: facebookresearch/ClassyVision#184 Differential Revision: D18364662 fbshipit-source-id: b6e5fd21df51b3974ffe0c0a092f097f00d7b915
vreis
force-pushed
the
export-D18364662
branch
from
c2cb47a
to
f49072c
Compare
There was a problem hiding this comment.
@vreis has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 18, 2019
Summary: Fixes a few small issues I found while invoking classy_train.py manually. The --config_file and --device arguments were required, but gave cryptic error messages when they were missing. Mark config_file as required and add good defaults for device. Pull Request resolved: #184 Test Plan: . Reviewed By: aadcock Differential Revision: D18364662 Pulled By: vreis fbshipit-source-id: 735f4156553754ac5bb9705084184fb8fe116724
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 18, 2019
Summary: Fixes a few small issues I found while invoking classy_train.py manually. The --config_file and --device arguments were required, but gave cryptic error messages when they were missing. Mark config_file as required and add good defaults for device. Pull Request resolved: #184 Test Plan: . Reviewed By: aadcock Differential Revision: D18364662 Pulled By: vreis fbshipit-source-id: 3fe41f34dca997b8aeb4ee8f9d658e6f72a320cc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D18364662