Stop storing configs in datasets #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
vreis
force-pushed
the
export-D17578858
branch
from
8f1c1cb
to
bfc29be
Compare
Summary: Pull Request resolved: facebookresearch/ClassyVision#21 In preparation to switch datasets to a .from_config constructor, make sure no datasets store the config itself as a member of the class. This makes things easier later. Differential Revision: D17578858 fbshipit-source-id: c5e9d22cb971c7dc6cf73431c28df09427290a03
vreis
force-pushed
the
export-D17578858
branch
from
bfc29be
to
096ddc7
Compare
|
This pull request has been merged in 1d75e08. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In preparation to switch datasets to a .from_config constructor, make sure no
datasets store the config itself as a member of the class. This makes things
easier later.
Differential Revision: D17578858