ClassyRandomClipSampler and ClassyUniformClipSampler #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D18523531 |
stephenyan1231
force-pushed
the
export-D18523531
branch
from
ae7afda
to
00f9781
Compare
|
This pull request was exported from Phabricator. Differential Revision: D18523531 |
stephenyan1231
force-pushed
the
export-D18523531
branch
from
00f9781
to
cfb0be5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D18523531 |
stephenyan1231
force-pushed
the
export-D18523531
branch
from
cfb0be5
to
f4592ea
Compare
|
This pull request was exported from Phabricator. Differential Revision: D18523531 |
stephenyan1231
force-pushed
the
export-D18523531
branch
from
f4592ea
to
ab98265
Compare
|
This pull request was exported from Phabricator. Differential Revision: D18523531 |
Summary: Pull Request resolved: facebookresearch/ClassyVision#218 `num_samples` argument is useful to limit the number of training samples we use from the dataset. But it is not effective for current video datasets such as `UCF101Dataset`. We extend TorchVision `RandomClipSampler` and `UniformClipSampler` to support `num_samples` argument. Differential Revision: D18523531 fbshipit-source-id: 86302abb53eb2b79dc382d80f6e5888843734d8e
stephenyan1231
force-pushed
the
export-D18523531
branch
from
ab98265
to
0090293
Compare
|
This pull request was exported from Phabricator. Differential Revision: D18523531 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 18, 2019
Summary: Pull Request resolved: #218 `num_samples` argument is useful to limit the number of training samples we use from the dataset. But it is not effective for current video datasets such as `UCF101Dataset`. We extend TorchVision `RandomClipSampler` and `UniformClipSampler` to support `num_samples` argument. Reviewed By: aadcock Differential Revision: D18523531 fbshipit-source-id: 39bd64762c6029ad84569d0b77d89460eb064837
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 18, 2019
Summary: Pull Request resolved: #218 `num_samples` argument is useful to limit the number of training samples we use from the dataset. But it is not effective for current video datasets such as `UCF101Dataset`. We extend TorchVision `RandomClipSampler` and `UniformClipSampler` to support `num_samples` argument. Reviewed By: aadcock Differential Revision: D18523531 fbshipit-source-id: 12c8c4bb71094a69ebbd8351d286d958840509c9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
num_samplesargument is useful to limit the number of training samples we use from the dataset. But it is not effective for current video datasets such asUCF101Dataset.We extend TorchVision
RandomClipSamplerandUniformClipSamplerto supportnum_samplesargument.Differential Revision: D18523531