Tolerate Linear layers without bias parameters in profiler #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: I've had the profiler break training twice in two weeks, disrupting my workflow. Add a global try/except. I think users would always want training to continue when model complexity can't be estimated. Differential Revision: D19700315 fbshipit-source-id: 2e278c1df2c005080c19adea1a9708d463e77c96
Summary: Handle `bias = None` as a registered parameter, as used in `Lienar(..., bias=False)`. Differential Revision: D19700470 fbshipit-source-id: 1bce47d79cad0e29c5551c36528705cbab2ab6d0
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D19700470 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 4, 2020
Summary: Pull Request resolved: #369 Handle `bias = None` as a registered parameter, as used in `Lienar(..., bias=False)`. Reviewed By: mannatsingh Differential Revision: D19700470 fbshipit-source-id: 286c1d40f1ead3d235ed5414aa72c7c8ff959e16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Handle
bias = Noneas a registered parameter, as used inLienar(..., bias=False).Differential Revision: D19700470