ResNeXt3D model #58
Closed
ResNeXt3D model #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D17311655 |
stephenyan1231
force-pushed
the
export-D17311655
branch
from
7d7de13
to
ef65aeb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D17311655 |
Summary: Pull Request resolved: facebookresearch/ClassyVision#58 Implement ResNeXt3D model on top of SlowFast codebase. Reviewed By: takatosp1 Differential Revision: D17311655 fbshipit-source-id: 65b6e86d41bb779143ec66c1a2672615a09f0b93
stephenyan1231
force-pushed
the
export-D17311655
branch
from
ef65aeb
to
f544a50
Compare
|
This pull request was exported from Phabricator. Differential Revision: D17311655 |
|
This pull request has been merged in 673ff73. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 22, 2020
Summary: Pull Request resolved: fairinternal/ClassyVision#58 The original hydra `args.yaml` was part of the classy vision package, which meant editing it in a classy project wasn't possible without changing the code. This diff makes changes so that the `args.yaml` is generated inside the project, giving users full control to the config. These are the changes being made - - Removed `classy_vision.generic.args` - the logic has been moved to `classy_train.py`. This was needed because otherwise the search happens inside the package and not in the file system. Also, if we only have hydra then there is almost no additional code. - Moved configs inside `classy_vision/hydra` to `classy_vision/hydra/conf` - Moved `args.yaml` to `templates/synthetic/hydra_configs` - Added a `hydra_plugins` package which tells hydra to add these bundled configs to the search path See the test plan for usage examples. NOTE: These changes are made with hydra-core 0.11 (latest release) in mind and will not work with the hydra master code. Reviewed By: vreis Differential Revision: D19418196 fbshipit-source-id: c2a5f046de75dde1eaf76ee0166308e30d47a9ac
vaibhava0
pushed a commit
to vaibhava0/ClassyVision
that referenced
this pull request
Jan 19, 2021
Summary: Pull Request resolved: fairinternal/ClassyVision#58 The original hydra `args.yaml` was part of the classy vision package, which meant editing it in a classy project wasn't possible without changing the code. This diff makes changes so that the `args.yaml` is generated inside the project, giving users full control to the config. These are the changes being made - - Removed `classy_vision.generic.args` - the logic has been moved to `classy_train.py`. This was needed because otherwise the search happens inside the package and not in the file system. Also, if we only have hydra then there is almost no additional code. - Moved configs inside `classy_vision/hydra` to `classy_vision/hydra/conf` - Moved `args.yaml` to `templates/synthetic/hydra_configs` - Added a `hydra_plugins` package which tells hydra to add these bundled configs to the search path See the test plan for usage examples. NOTE: These changes are made with hydra-core 0.11 (latest release) in mind and will not work with the hydra master code. Reviewed By: vreis Differential Revision: D19418196 fbshipit-source-id: c2a5f046de75dde1eaf76ee0166308e30d47a9ac
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Implement ResNeXt3D model on top of SlowFast codebase.
Reviewed By: takatosp1
Differential Revision: D17311655