Keep dataloaders, model, meters as members of ClassyTask #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: While moving everything to the classy_vision module I missed this file. It doesn't make sense to have it in the root directory, move it where it belongs. Differential Revision: D17515540 fbshipit-source-id: cecf411fee9d3af078d793b46b1099017dc303a7
Summary: This will make more sense after you review D17515697: I'm hiding ClassyState from the public API, but in some cases we access state.optimizer, state.model etc. This diff adds these members to ClassyTask so it can replace the state. Eventually I want to move these from the state to the task, but for now we need them in both. Differential Revision: D17515732 fbshipit-source-id: 1dad09afaca2321b0c7c8668e36af6ac27d65065
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 24, 2019
Summary: Pull Request resolved: #8 This will make more sense after you review D17515697: I'm hiding ClassyState from the public API, but in some cases we access state.optimizer, state.model etc. This diff adds these members to ClassyTask so it can replace the state. Eventually I want to move these from the state to the task, but for now we need them in both. Reviewed By: mannatsingh Differential Revision: D17515732 fbshipit-source-id: e00820cf608dfc86a658e293e8446b6ae10b36a0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This will make more sense after you review D17515697: I'm hiding ClassyState
from the public API, but in some cases we access state.optimizer, state.model
etc. This diff adds these members to ClassyTask so it can replace the state.
Eventually I want to move these from the state to the task, but for now we
need them in both.
Differential Revision: D17515732