Refactor trainer API #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
vreis
force-pushed
the
export-D17515697
branch
from
e903654
to
7b163b6
Compare
Summary: This will make more sense after you review D17515697: I'm hiding ClassyState from the public API, but in some cases we access state.optimizer, state.model etc. This diff adds these members to ClassyTask so it can replace the state. Eventually I want to move these from the state to the task, but for now we need them in both. Differential Revision: D17515732 fbshipit-source-id: 4fd56ddd32ed52552bbd151111e99eebf0a039a0
Summary: Pull Request resolved: facebookresearch/ClassyVision#9 Move things around a bit more to get closer to our goal. Introduce a ClassyTrainer.train method, which only takes a task in. The state is hidden from the public API that way. Other parameters are passed in the constructor instead. Reviewed By: mannatsingh Differential Revision: D17515697 fbshipit-source-id: 950847157046998622e97c44628275fbf14f66b5
vreis
force-pushed
the
export-D17515697
branch
from
7b163b6
to
66b8931
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 24, 2019
Summary: Pull Request resolved: #9 Move things around a bit more to get closer to our goal. Introduce a ClassyTrainer.train method, which only takes a task in. The state is hidden from the public API that way. Other parameters are passed in the constructor instead. Reviewed By: mannatsingh Differential Revision: D17515697 fbshipit-source-id: 1d4163f1c49a0a29c5bbf8fc01eda88e810dbed3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Move things around a bit more to get closer to our goal. Introduce a
ClassyTrainer.train method, which only takes a task in. The state is hidden
from the public API that way. Other parameters are passed in the constructor
instead.
Differential Revision: D17515697