[3/N] Add critical path analysis GPU->GPU sync dependencies #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@briancoutinho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
anupambhatnagar
approved these changes
Oct 10, 2023
| .sort_values(by="ts", axis=0) | ||
| ) | ||
|
|
||
| def previous_launch(ts: int, pid: int, tid: int) -> Optional[int]: |
There was a problem hiding this comment.
rename to _previous_launch?
| def previous_launch(ts: int, pid: int, tid: int) -> Optional[int]: | ||
| """Find the previous CUDA launch on same pid and tid""" | ||
| df = runtime_calls.query(f"pid == {pid} and tid == {tid}") | ||
| lowerneighbours = df[df["ts"] < ts]["ts"] |
There was a problem hiding this comment.
*nit - lower_neighbors
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
==========================================
+ Coverage 90.94% 91.06% +0.11%
==========================================
Files 30 30
Lines 2507 2562 +55
==========================================
+ Hits 2280 2333 +53
- Misses 227 229 +2
☔ View full report in Codecov by Sentry. |
|
@briancoutinho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@briancoutinho merged this pull request in 66e3c54. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This final PR adds the smarts to infer inter stream (GPU->GPU) synchronization dependencies.
How it works?
The core part of the logic is to understand synchronization due to CUDA events.
_get_cuda_event_record_df()(Happy to discuss in person - this was convoluted)
Other changes
get_runtime_launch_events_query(). This is used in kernel analyzer as well.Test:
Below is an example of inter GPU stream sync, see arrow between events.
Before submitting