Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing requirement #84

Closed

Conversation

omrihaber
Copy link
Contributor

Kats

Thank you for contributing! Please take a moment to review our contributing guidelines
to make the process easy and effective for everyone involved.

  • Fork the repo and create your branch from master.
  • If you've added code that should be tested, add tests.
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes.
  • Make sure your code lints.
  • If you haven't already, complete the Contributor License Agreement ("CLA").

Contributor License Agreement ("CLA")
In order to accept your pull request, we need you to submit a CLA. You only need to do this once to work on any of Facebook's open source projects.

Complete your CLA here: https://code.facebook.com/cla

Ver: Kats v1.02

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 14, 2021
@omrihaber
Copy link
Contributor Author

I saw the CI failing because of a library called deprecated which is missing from the requirements.txt

Should these requirements be separate from the requirements.txt and create a test_requirements.txt or all of the dependencies for testing and development are stated at requirements.txt?

@facebook-github-bot
Copy link
Contributor

@michaelbrundage has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@michaelbrundage
Copy link
Contributor

Thank you for this bug fix!

@omrihaber
Copy link
Contributor Author

omrihaber commented Jul 15, 2021

@michaelbrundage Can you merge the PR?

@facebook-github-bot
Copy link
Contributor

@michaelbrundage merged this pull request in c04cd46.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants