Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

Fix missing parenthesis in folding #24

Closed
wants to merge 1 commit into from

Conversation

fxmarty
Copy link

@fxmarty fxmarty commented Aug 10, 2022

These missing parenthesis may be somewhere else as well.

These missing parenthesis may be somewhere else as well.
@facebook-github-bot
Copy link

Hi @fxmarty!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@btgraham
Copy link
Contributor

Re: https://pytorch.org/docs/stable/generated/torch.nn.BatchNorm1d.html#torch.nn.BatchNorm1d
Are parenthesis really missing on L122? If the input and bn.running_mean are exactly zero, I think the output of the combined 'Linear+BatchNorm' operation should be exactly equal to bn.bias. So I don't think we should dividebn.bias by (bn.running_var + bn.eps)**0.5 when forming m??

@fxmarty
Copy link
Author

fxmarty commented Aug 10, 2022

@btgraham Right, I misread, my bad!

@fxmarty fxmarty closed this Aug 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants