Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional python versions to test #925

Merged
merged 1 commit into from
Feb 10, 2023
Merged

Add additional python versions to test #925

merged 1 commit into from
Feb 10, 2023

Conversation

pringshia
Copy link
Contributor

@pringshia pringshia commented Nov 7, 2022

Closes #924 by introducing additional Python versions to the scheduled matrix testing.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 7, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 64.26% // Head: 64.22% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (fc56f30) compared to base (66be164).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #925      +/-   ##
==========================================
- Coverage   64.26%   64.22%   -0.05%     
==========================================
  Files         108      108              
  Lines        9405     9405              
==========================================
- Hits         6044     6040       -4     
- Misses       3361     3365       +4     
Impacted Files Coverage Δ
mephisto/abstractions/architects/mock_architect.py 88.23% <0.00%> (-2.62%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JackUrb
Copy link
Contributor

JackUrb commented Nov 8, 2022

Once concern here: we'll be marked as failing entirely on main whenever this runs until the downstream issue in hydra<->python3.11 is resolved. It'd be nice to tie individual python versions to something we could tag on the github landing (like a badge) for each of these versions?

@pringshia pringshia changed the title Add additional python versions to test [wip] Add additional python versions to test Nov 8, 2022
@pringshia pringshia changed the title [wip] Add additional python versions to test Add additional python versions to test Jan 30, 2023
@pringshia
Copy link
Contributor Author

pringshia commented Jan 30, 2023

@JackUrb - we don't show tests on the main README anymore so this shouldn't be an issue. Also the downstream Hydra issue is now resolved anyway. Are we ok to merge this in now?

@JackUrb JackUrb merged commit 4922242 into main Feb 10, 2023
@JackUrb JackUrb deleted the update-matrix branch February 10, 2023 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mephisto incompatible with Python 3.11
4 participants