Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Commit

Permalink
feat: add exception handling to _unzip method in build_data.py to con… (
Browse files Browse the repository at this point in the history
#4572)

* feat: add exception handling to _unzip method in build_data.py to continue execution even when some files fail to extract

* fix lint error
  • Loading branch information
chiehminwei authored and kushalarora committed Jun 15, 2022
1 parent 55ad639 commit fd5dc88
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions parlai/core/build_data.py
Expand Up @@ -380,8 +380,13 @@ def _unzip(path, fname, delete=True):
PathManager.mkdirs(outpath)
continue
logging.debug(f"Extracting to {outpath}")
with zf.open(member, 'r') as inf, PathManager.open(outpath, 'wb') as outf:
shutil.copyfileobj(inf, outf)
try:
with zf.open(member, 'r') as inf, PathManager.open(
outpath, 'wb'
) as outf:
shutil.copyfileobj(inf, outf)
except FileNotFoundError:
logging.error(f"Failed to open ${member} and extract to ${outpath}")
if delete:
try:
PathManager.rm(fullpath)
Expand Down

0 comments on commit fd5dc88

Please sign in to comment.