Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

update pillow to 7.2.0 from 6.2.2 #2896

Merged
merged 2 commits into from Jul 28, 2020
Merged

Conversation

alexholdenmiller
Copy link
Member

@alexholdenmiller alexholdenmiller commented Jul 28, 2020

Patch description
update pillow version in requirements.py to 7.2.0 which is included with pytorch 1.4.0

Testing steps

conda create -n pillow python=3.7
source activate pillow
module purge && module activate cuda/10.1 cudnn/v7.6.5.32-cuda.10.1 NCCL/2.5.6-1-cuda.10.1
conda install pytorch=1.4.0 torchvision cudatoolkit=10.1 -c pytorch

python -m pip install --progress-bar off --upgrade pip setuptools
python -m pip install --progress-bar off coverage
python -m pip install --progress-bar off codecov
mkdir -p ~/ParlAI/test-results
pip install -v -r requirements.txt
python -c "import nltk; nltk.download('punkt')"

cd ~/ParlAI && python setup.py develop

python -m pytest -m unit

Logs
I had a number of weird transient test failures (mostly due to weird issues around installing things in a bad way) but there are no failures due to Pillow.

@alexholdenmiller alexholdenmiller marked this pull request as ready for review July 28, 2020 18:24
@alexholdenmiller alexholdenmiller changed the title [WIP] update pillow to 7.1.0 from 6.2 [WIP] update pillow to 7.2.0 from 6.2 Jul 28, 2020
@alexholdenmiller alexholdenmiller changed the title [WIP] update pillow to 7.2.0 from 6.2 update pillow to 7.2.0 from 6.2 Jul 28, 2020
@alexholdenmiller alexholdenmiller changed the title update pillow to 7.2.0 from 6.2 update pillow to 7.2.0 from 6.2.2 Jul 28, 2020
@alexholdenmiller
Copy link
Member Author

(feel free to merge on accept)

Copy link
Contributor

@stephenroller stephenroller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@stephenroller stephenroller merged commit 78e050c into master Jul 28, 2020
@stephenroller stephenroller deleted the alexholdenmiller-patch-1 branch July 28, 2020 20:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants