Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Test parlai/core/script.py #3117

Merged
merged 3 commits into from Sep 30, 2020
Merged

Test parlai/core/script.py #3117

merged 3 commits into from Sep 30, 2020

Conversation

stephenroller
Copy link
Contributor

Patch description
Add tests for the abstract class in script.py, and the supercommand.

Testing steps
New CI.

$ coverage report parlai/core/script.py
Name                    Stmts   Miss  Cover
-------------------------------------------
parlai/core/script.py     137      2    99%

Copy link
Contributor

@klshuster klshuster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

big fan of this, hopefully this will catch the super subtle differences that sometimes come up between e.g. parlai tm and python -m parlai.scripts.train_model - ideally we can continue adding tests to this for maximum robustness

tests/test_script.py Show resolved Hide resolved
tests/test_script.py Outdated Show resolved Hide resolved
@stephenroller stephenroller merged commit d68b314 into master Sep 30, 2020
@stephenroller stephenroller deleted the testcore branch September 30, 2020 03:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants