This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Add jga metric to taskmaster2 #3134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: I'm currently running a quick local training with jga as the metric to make sure it's functioning properly (cause trying `parlai eval_model -m bart -t taskmaster2` off the bat has 0s in both `slot_r` and `jga` right now), but figured the metric is easy enough to warrant getting review on it sooner rather than later.
|
Your PR contains a change to a task. Please paste the results of the following command into a comment: python tests/datatests/test_new_tasks.py |
stephenroller
approved these changes
Sep 30, 2020
| @@ -171,6 +171,9 @@ def custom_evaluation( | |||
| f'{domain}_slot_r', | |||
| AverageMetric(correct, len(teacher_action['slots'])), | |||
| ) | |||
| self.metrics.add( | |||
| 'jga', AverageMetric(correct == len(teacher_action['slots'])) | |||
There was a problem hiding this comment.
It might be more readable for us to just compare the dictionaries (see FB:multiwoz code), but this works.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fairly straightforward.
Test Plan:
Ran an eval model with the model that I had trained previously on taskmaster2 w/ PPL as a metric locally.