Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Adding option for file with annotation indices per conversation and other features to turn annotations static #3154

Merged
merged 3 commits into from Oct 12, 2020
Merged

Adding option for file with annotation indices per conversation and other features to turn annotations static #3154

merged 3 commits into from Oct 12, 2020

Conversation

mwillwork
Copy link
Contributor

@mwillwork mwillwork commented Oct 5, 2020 •
edited

Adding features to turn annotations static task:

  • Optional params handled in run_task (though this will get handled differently upon merge to Hydra)
  • New params:
    • Setting random seed
    • Option to supply a second file specifying which utterance indices to annotation in each conversation
    • Conversation count: only take the first N conversations of the data file
    • Being able to customize the annotation question

@EricMichaelSmith I think this should get merged in before you merge your PR to convert to Hydra

@mwillwork mwillwork changed the title black changes Adding features to turn annotations static Oct 5, 2020
EricMichaelSmith
EricMichaelSmith approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@EricMichaelSmith EricMichaelSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine - if you merge this in, I can revise my Hydra PR

parlai/crowdsourcing/tasks/turn_annotations_static/run_task.py Show resolved Hide resolved
@stephenroller
Copy link
Contributor

Can we have a slightly more descriptive PR title before merging?

@mwillwork mwillwork changed the title Adding features to turn annotations static Adding option for file with annotation indices per conversation and other features to turn annotations static Oct 5, 2020
@mwillwork mwillwork merged commit d736133 into master Oct 12, 2020
@mwillwork mwillwork deleted the turn-annotations-static-add-features branch October 12, 2020 13:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@EricMichaelSmith EricMichaelSmith EricMichaelSmith approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mwillwork @stephenroller @EricMichaelSmith @facebook-github-bot