This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
fix dialogpt dual usage of END_IDX #3256
Merged
Merged
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
6ade0eb
fix dialogpt dual usage of endoftext
jxmsML 0946ef0
add null_idx = -1
jxmsML 0a37ef0
dialog bs test
jxmsML 7ee25bf
Set null_idx in model and decoder, add to dialogpt test
jxmsML 3665e94
small formats
jxmsML 38796fd
accidental delete old test
jxmsML 590ceb7
reviewer comment
jxmsML 1fec4f8
Merge branch 'master' into dialogptdebug
jxmsML File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,9 +12,14 @@ | |
import parlai.scripts.build_dict as build_dict | ||
import os | ||
import copy | ||
from parlai.utils.misc import warn_once | ||
|
||
|
||
class TestGpt2(unittest.TestCase): | ||
warn_once( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. just a comment, not a warning plz |
||
'WARNING: DID YOU IMPLEMENT A TEST FOR DIALOGPT TOO? YOU KNOW YOU NEED TO TEST IT TOO!' | ||
) | ||
|
||
def _test_batchsize(self, batchsize, add_start_token): | ||
utterances = [ | ||
'Just keep swimming -', | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need the warning? IDTS, no?