Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Fix issue #3502: "Message already contains key dyn_batch_idx" #3505

Merged
merged 2 commits into from Mar 12, 2021

Conversation

frankplus
Copy link
Contributor

Patch description
This PR fixes issue #3502
self._task_acts[i]['dyn_batch_idx'] = i was setting a value for a key that was already set throwing error Message already contains key 'dyn_batch_idx'.

Simply replacing it with self._task_acts[i].force_set('dyn_batch_idx', i) fixed the problem.

Testing steps
Tested by running python3 tests/test_dynamicbatching.py without any problem.

@facebook-github-bot
Copy link

Hi @frankplus!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Contributor

@stephenroller stephenroller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will wait for tests to pass and then merge, thanks for fixing!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@frankplus
Copy link
Contributor Author

The CircleCI test seems to fail for a reason unrelated to the changes made in this PR. Is there anything I could do to fix it?

@stephenroller stephenroller merged commit 588723b into facebookresearch:master Mar 12, 2021
@stephenroller
Copy link
Contributor

Nah I agree this isn't your problem. Thanks for your contribution!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants