This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Switched logging.warn to logging.warning #3569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenroller
approved these changes
Apr 2, 2021
|
The segfault in gpu tests isn't related, but hold on merging a bit please. |
|
Actually your branch is from an old parent (np) so this isn't unexpected. You're good to merge whenever. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
Currently there are two ways to log warnings: logging.warn() and logging.warning().
This PR switches all logging.warn() usages to logging.warning() and removes logging.warn() implementation.
Besides removing ambiguity, this change is also inline with Python 3.3 warn vs warning naming.
Testing steps
Unit tests.