Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Speed up test_crossencoder #3587

Merged
merged 1 commit into from Apr 14, 2021
Merged

Speed up test_crossencoder #3587

merged 1 commit into from Apr 14, 2021

Conversation

stephenroller
Copy link
Contributor

Patch description
Speed up one of our slower, flaky tests. As far as I can tell this is about 2x faster and doesn't fail (while having a higher threshold for accuracy lol). Major change is switching to an overfit dataset.

Testing steps
New CI and local pytest runs.

@stephenroller
Copy link
Contributor Author

In this commit:

146.22s call     tests/nightly/gpu/test_bert.py::TestBertModel::test_biencoder
81.06s call     tests/nightly/gpu/test_bert.py::TestBertModel::test_crossencoder

In a recent master commit:

466.35s call     tests/nightly/gpu/test_bert.py::TestBertModel::test_biencoder
358.52s call     tests/nightly/gpu/test_bert.py::TestBertModel::test_crossencoder

@stephenroller stephenroller merged commit 138bfd5 into master Apr 14, 2021
@stephenroller stephenroller deleted the test_crossencoder branch April 14, 2021 15:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants