Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Fixing BB2 bugs #3803

Merged
merged 14 commits into from Jul 16, 2021
Merged

Fixing BB2 bugs #3803

merged 14 commits into from Jul 16, 2021

Conversation

mojtaba-komeili
Copy link
Contributor

Patch description
After adding the BB2 code and its related modules, some of the tests are failing. This is fix the unittest failures.

Testing steps
CircleCI tests are clear.

@mojtaba-komeili
Copy link
Contributor Author

@stephenroller any idea why gpu17 is failing? It complains about tests/test_distributed.py, but I ran it locally and it was fine.

@mojtaba-komeili mojtaba-komeili merged commit 5fc84c6 into master Jul 16, 2021
@mojtaba-komeili mojtaba-komeili deleted the bb2-bugfix branch July 16, 2021 20:22
@mojtaba-komeili mojtaba-komeili restored the bb2-bugfix branch July 16, 2021 20:27
@@ -55,7 +55,7 @@ acts:
of measles in the United States in 2002 .'
- - episode_done: true
eval_labels:
- equivalent
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did this change? That seems concerning?

@mojtaba-komeili mojtaba-komeili deleted the bb2-bugfix branch July 20, 2021 15:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants