Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Retry flaky crowdsourcing tests #3825

Merged
merged 1 commit into from Jul 21, 2021
Merged

Retry flaky crowdsourcing tests #3825

merged 1 commit into from Jul 21, 2021

Conversation

EricMichaelSmith
Copy link
Contributor

Patch description
Retry crowdsourcing tests that are flaky due to sockets closing without warning, occasional missing messages, etc.

Testing steps
CI checks

@EricMichaelSmith EricMichaelSmith marked this pull request as ready for review July 20, 2021 22:36
@mojtaba-komeili mojtaba-komeili self-requested a review July 21, 2021 14:22
mojtaba-komeili
mojtaba-komeili approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@mojtaba-komeili mojtaba-komeili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Eric. This had caused some pain for me before. Glad to see this.

JackUrb
JackUrb approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@JackUrb JackUrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good to me - The underlying issue I think is in the MockArchitect's MockServer websockets closing unexpectedly without a retried connection, but retries are a good solution until I can dig into that on the Mephisto side.

@EricMichaelSmith EricMichaelSmith merged commit b18adfd into master Jul 21, 2021
@EricMichaelSmith EricMichaelSmith deleted the retry-flaky-crowdsourcing-tests branch July 21, 2021 21:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JackUrb JackUrb JackUrb approved these changes

@mojtaba-komeili mojtaba-komeili mojtaba-komeili approved these changes

@stephenroller stephenroller Awaiting requested review from stephenroller

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@EricMichaelSmith @JackUrb @mojtaba-komeili @facebook-github-bot