This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
[BB2] Handle Distributed #4023
Merged
[BB2] Handle Distributed #4023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -507,7 +515,7 @@ def _set_query_vec(self, observation: Message) -> Message: | |||
| ) | |||
| if self.add_person_tokens: | |||
| query_str = self._remove_person_tokens(query_str) | |||
| observation['query_vec'] = self.model.tokenize_query(query_str) | |||
| observation['query_vec'] = self.model_api.tokenize_query(query_str) | |||
There was a problem hiding this comment.
Shouldn't this be self.model_api().tokenize_query(query_str)?
There was a problem hiding this comment.
idts, model_api is a @property
Kurt, maybe we should bump this all the way up to TA. We have this module stuff everywhere
There was a problem hiding this comment.
Oh, yeah right. I missed that.
There was a problem hiding this comment.
bump up to TA
We would need to think of an elegant solution so that we can still call self.model() directly (which does work in distributed). We could solve it with model_api if you think that's appropriate
mojtaba-komeili
approved these changes
Sep 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
Make sure we don't directly access functions from
self.modelif we're in distributed mode. Fixes issue pointed out in #3872Follows very closely the solution in #3787
Testing steps
Verified that bb2 tests still pass.