This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
[Modular] Update Transformer Layer __init__s
#4061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jxmsML
approved these changes
Oct 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
The
TransformerDecoder(Layer)andTransformerEncoder(Layer)support passing**kwargsfor maximum customizability; however, these**kwargsare unnecessarily (and, actually, incorrectly) being passed to thenn.Module'ssuper().__init__(), which doesn't accept arbitrary**kwargs. This patch removes these from the super callTesting steps
Subclassed a
TransformerEncoder, attempted to initialize with arbitrary parameters, confirmed it works after fix.