Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Fix model chat speakers and personas #4273

Merged
merged 5 commits into from Jan 4, 2022

Conversation

EricMichaelSmith
Copy link
Contributor

@EricMichaelSmith EricMichaelSmith commented Dec 23, 2021

Patch description

  • When running the model chat task, display the speaker names as "Speaker 1" and "Speaker 2" instead of showing the Turker the name of the model id ("TransformerGenerator", etc.)
    • Change this for both the regular model chat and the image chat variant
  • Also, allow the persona strings to be shown on the left-hand pane if your pane's text includes the strings "[persona_string_1]" or "[persona_string_2]"
  • Also fix an issue with using run.py to run model image chat: worlds_image_chat.py wasn't being set as the correct words file

Testing steps

Regular model chat

Command:

python parlai/crowdsourcing/tasks/model_chat/run.py \
mephisto.architect.port=3002 \
mephisto.task.maximum_units_per_worker=1000000

Before

Screen Shot 2021-12-23 at 1 23 29 PM

After

Screen Shot 2021-12-23 at 2 01 15 PM

Model image chat

Command:

python parlai/crowdsourcing/tasks/model_chat/run.py \
mephisto.architect.port=3002 \
conf=example_image_chat \
mephisto.task.maximum_units_per_worker=1000000

Before

Screen Shot 2021-12-23 at 1 49 36 PM

After

Screen Shot 2021-12-23 at 2 00 07 PM

Testing showing the personas on the left-hand side

Example:

SM-Turn UI with refactored code

@EricMichaelSmith EricMichaelSmith changed the title [WIP] Display model chat speakers and personas [WIP] Fix model chat speakers and personas Dec 23, 2021
@EricMichaelSmith EricMichaelSmith changed the title [WIP] Fix model chat speakers and personas Fix model chat speakers and personas Dec 23, 2021
@EricMichaelSmith EricMichaelSmith marked this pull request as ready for review December 23, 2021 20:27
Copy link
Contributor

@meganung meganung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes and keeping the tests up to date too!

@EricMichaelSmith EricMichaelSmith merged commit 6df9361 into main Jan 4, 2022
@EricMichaelSmith EricMichaelSmith deleted the display-correct-model-chat-speakers branch January 4, 2022 14:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants