This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Fixes train_model worldlogging for multitask with mutators. #4414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jxmsML
reviewed
Mar 15, 2022
| """ | ||
| with testing_utils.tempdir() as tmpdir: | ||
| log_report = os.path.join(tmpdir, 'world_logs.jsonl') | ||
| multitask = 'integration_tests:mutators=flatten,integration_tests:ReverseTeacher:mutator=reverse' |
There was a problem hiding this comment.
I wonder if we can test this with integration_tests:mutators=flatten,integration_tests:mutator=reverse to highlight that you wanted to test if world logs works for exact same teacher except for mutators
There was a problem hiding this comment.
I was just trying to convey that the two tasks can be anything, it's the number of tasks that matter. So it works for any two tasks.
jxmsML
suggested changes
Mar 15, 2022
jxmsML
approved these changes
Mar 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
Worldlogging is broken in the train_model script in the multitask setting with mutators bcoz world.getID() omits the mutators and doesn't match the task name.
Testing steps
pytest tests/test_train_model.py
Other information