Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Fix bug of #4454 #4455

Closed
wants to merge 1 commit into from
Closed

Conversation

edwardyoon
Copy link

Patch description

Testing steps

Other information

@facebook-github-bot
Copy link

Hi @edwardyoon!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

Copy link
Contributor

@stephenroller stephenroller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, can you leave a description of your patch?

@klshuster
Copy link
Contributor

Didn't see this but this, along with other related issues, are fixed in #4459. problem is described there as well

@stephenroller
Copy link
Contributor

Since CLA isn't signed and there's another patch, closing this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants