This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
[SeeKeR] Opt construction for Python 3.8 #4458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
projects/seeker/agents/seeker.py
Outdated
| @@ -201,7 +201,7 @@ def add_additional_subagent_args(cls, parser: ParlaiParser) -> ParlaiParser: | |||
| """ | |||
| additional_agent_parser = cls.get_additional_agent_args() | |||
| for action in additional_agent_parser._actions: | |||
| key = action.option_strings[-1] | |||
| key = sorted(action.option_strings, key=lambda x: len(x))[-1] | |||
There was a problem hiding this comment.
nit: do you think using max makes it slightly shorter? You wouldn't need the [-1].
There was a problem hiding this comment.
oh yeah good point.
edit: we'll still need to index into action.option_strings so not sure how that would look practically
There was a problem hiding this comment.
since we're dealing with strings not numbers
There was a problem hiding this comment.
I don't understand, the behavior shouldn't change between the max or sort here.
mojtaba-komeili
approved these changes
Mar 28, 2022
|
sorry i totally forgot |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
Fixes issue in #4451
The opt construction for sub-opts for each agent takes the final option string in the parser; for python < 3.8, this would always be the
--option when a-was also present. In Python >=3.8, this seems to be non-deterministic.The new logic ensures we get the long option every time.
Testing steps
Tested sample commands from #4451