This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
[minor][wandb] Save task arguments as separate config values #4484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 5, 2022 07:32
Convenience so that we can do UI filters in wandb on values for task arguments.
```
>>> from parlai.core.logs import WandbLogger
>>> opt= {"wandb_name": "test_3", "wandb_project": "blah_2", "model_file": "dummy_mf", "task": "blah:x=y:a=2"}
>>> dummy = WandbLogger(opt)
>>> dummy.run.config
{'wandb_name': 'test_3', 'wandb_project': 'blah_2', 'model_file': 'dummy_mf', 'task': 'blah:x=y:a=2', 'x': 'y', 'a': '2'}
| if not self.run.resumed: | ||
| for key, value in opt.items(): | ||
| if value is None or isinstance(value, (str, numbers.Number, tuple)): | ||
| setattr(self.run.config, key, value) | ||
| set_config_value(self, key, value) | ||
| if key == "task": # For ags specified in the task argument |
| @@ -181,14 +181,25 @@ def __init__(self, opt: Opt, model=None): | |||
| entity=opt.get('wandb_entity'), | |||
| reinit=True, # in case of preemption | |||
| resume=True, # requeued runs should be treated as single run | |||
| allow_val_change=True, | |||
There was a problem hiding this comment.
Can you leave a comment why
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convenience so that we can do UI filters in wandb on values for task arguments.
Test plan:
Also ran a run on SLURM.