This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Search query API timeout and retry #4631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@klshuster I am working on making requests async. Don't review it yet. I will ping you again when it was ready. |
Given other priorities, pushing this for later. Let's go with this version for now. |
klshuster
approved these changes
Jun 27, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
Right now, the
SearchEngineRetrieveragent sends a single search request to the search server and waits on that. Without timeout, this may mean that the agent will be blocked until receiving a response (which may never happen). Also upon failure on request, it does not retry. This patch solve this issue.Two more opt are added the to the agent:
search_server_timeoutthat controls timeout in secondsmax_num_retriesfor the number of times to retry until there is a 200 response from the server.