This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Fixed T5 and GPT2 related bugs in the hugging_face agents #4648
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
Previously T5 dictionary was undefined and elements of the huggingface dictionary agent were uninitialized leading to immediate exceptions in the train step for T5 and at the beginning of the validation step for GPT2 when training using train_model.py and the latest versions of HuggingFace
Testing steps
Verify that
python parlai/scripts/train_model.py --m hugging_face/t5 --t multiwoz_v22 --mf ~/t5test --truncate 512 --vstep 150 --max-train-steps 300
andpython parlai/scripts/train_model.py --m hugging_face/gpt2 --t multiwoz_v22 --mf ~/gpt2test --truncate 512 --vstep 150 --max-train-steps 300
successfully terminate without exceptionsOther information
As discussed with Kurt and Andrew previously