This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Modelchat worker qual #4956
Merged
Modelchat worker qual #4956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
probably good to have @EricMichaelSmith's review here but it all looks good to me |
EricMichaelSmith
approved these changes
Feb 22, 2023
| @@ -47,7 +50,17 @@ def run_task(cfg: DictConfig, task_directory: str, world_module=None): | |||
| soft_block_mturk_workers(cfg=cfg, db=db, soft_block_qual_name=soft_block_qual_name) | |||
|
|
|||
| # Init | |||
| shared_state = SharedModelChatTaskState(world_module=world_module) | |||
| if cfg.mephisto.blueprint.allowed_worker_qualification is not None: | |||
There was a problem hiding this comment.
Should we add a TODO to bubble this functionality up to all ParlAI Mephisto tasks in the future?
|
Thanks for the comments @EricMichaelSmith. Good suggestion for moving the functionality up to the parent. I added the TODO for now to avoid the potential unintended effects. But we can come back to it later. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description