Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

[Crowdsourcing] Fix 2 critical errors with static turn annotations #4959

Merged
merged 2 commits into from Feb 23, 2023

Conversation

EricMichaelSmith
Copy link
Contributor

@EricMichaelSmith EricMichaelSmith commented Feb 17, 2023

Patch description

  • Fixes frontend error in static_turn_annotations, caused by frontend supplying a temporary taskData object in the interim transitioning between onboarding and the full world
  • Fixes the issue that the final submitted data needs to be part of a dict with a 'final_data' key

(thanks @JackUrb for the fixes!)

Testing steps

python parlai/crowdsourcing/tasks/turn_annotations_static/run.py \
conf=test00.yaml \
mephisto.database._database_type=singleton \
mephisto.log_level=debug \
mephisto.task.maximum_units_per_worker=100000 \
mephisto.blueprint.onboarding_qualification=test_2023_02_17__04 \
--config-dir ${DIR}`

@EricMichaelSmith EricMichaelSmith changed the title [Crowdsourcing] Fix frontend error after onboarding [Crowdsourcing] Fix 2 critical errors with static turn annotations Feb 18, 2023
Copy link
Contributor

@meganung meganung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

@EricMichaelSmith EricMichaelSmith merged commit c4c0778 into main Feb 23, 2023
@EricMichaelSmith EricMichaelSmith deleted the static-turn-annotations-load-error branch February 23, 2023 15:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants