Untiered docker images for easy Jenkins setup #91
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1000 for dropping docker/common/install_cuda.sh
and using the NVIDIA provided image.
So I am still having issues understanding why we need to explicitly install the compiler that IIRC comes by default with the particular distribution ( My current understanding is that there were libstdc++ version / linking issues when mixing this with conda. Is that accurate? I think it's ok to punt on the investigation if it requires non-trivial extra work. |
this is a safety measure, if someone wants to play with the trusty image but use gcc5.4 let's say then they will know that the image corresponds to what gcc version explicitly and things won't silently fail. Conda also ships its own gcc and libstdc++ and given the light of this, I find it better to be explicit. it affects protobuf as well. nothing more to investigate on this :) |
got it, explicit trumps implicit, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
a4d448d
to
63337a4
Compare
thanks @zdevito :) |
moving the docker images to base off of nvidia docker images and make them non-tiered
closes #79