Skip to content
This repository has been archived by the owner on Apr 28, 2023. It is now read-only.

Untiered docker images for easy Jenkins setup #91

Merged
merged 1 commit into from Mar 2, 2018
Merged

Conversation

prigoyal
Copy link
Contributor

@prigoyal prigoyal commented Mar 1, 2018

moving the docker images to base off of nvidia docker images and make them non-tiered

closes #79

Copy link
Contributor

@nicolasvasilache nicolasvasilache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1000 for dropping docker/common/install_cuda.sh and using the NVIDIA provided image.

@nicolasvasilache
Copy link
Contributor

So I am still having issues understanding why we need to explicitly install the compiler that IIRC comes by default with the particular distribution (gcc-4.8 for trusty and gcc-5 for xenial).

My current understanding is that there were libstdc++ version / linking issues when mixing this with conda. Is that accurate?

I think it's ok to punt on the investigation if it requires non-trivial extra work.
But if you have more details already, I'd still like to understand what the problem is.

@prigoyal
Copy link
Contributor Author

prigoyal commented Mar 1, 2018

So I am still having issues understanding why we need to explicitly install the compiler that IIRC comes by default with the particular distribution (gcc-4.8 for trusty and gcc-5 for xenial).

this is a safety measure, if someone wants to play with the trusty image but use gcc5.4 let's say then they will know that the image corresponds to what gcc version explicitly and things won't silently fail. Conda also ships its own gcc and libstdc++ and given the light of this, I find it better to be explicit. it affects protobuf as well.

nothing more to investigate on this :)

@prigoyal prigoyal requested review from zdevito and ftynse March 1, 2018 22:54
@nicolasvasilache
Copy link
Contributor

got it, explicit trumps implicit, thanks!

Copy link
Contributor

@nicolasvasilache nicolasvasilache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@prigoyal prigoyal changed the title [wip] Untiered docker images for easy Jenkins setup Untiered docker images for easy Jenkins setup Mar 2, 2018
@prigoyal prigoyal requested review from wsmoses and abadams March 2, 2018 21:44
@prigoyal
Copy link
Contributor Author

prigoyal commented Mar 2, 2018

thanks @zdevito :)

@prigoyal prigoyal merged commit c215ae2 into master Mar 2, 2018
@prigoyal prigoyal deleted the untier-docker branch March 2, 2018 22:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker images improvement - non tiered version
4 participants