This repository has been archived by the owner on Dec 18, 2023. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Summary: ### Motivation Fixes https://github.com/facebookresearch/beanmachine/runs/4567109442?check_suite_focus=true ### Changes proposed Pins usort version. Per neerajprad > I am able to replicate this locally. The issue is that usort was recently updated to 1.0.0 and they seem to have added case insensitivity to the sort order. The command to run is usort check . after upgrading the usort version (see the test run that failed on the last commit: https://github.com/facebookresearch/beanmachine/runs/4567109442?check_suite_focus=true). e.g. diff on a file. Not sure what the reasons are for this change, and I couldn't see a way to change the default in the config either. Pull Request resolved: #1285 Test Plan: GH actions ### Types of changes - [x] Docs change / refactoring / dependency upgrade - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ### Checklist - [x] My code follows the code style of this project. - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [x] I have read the **[CONTRIBUTING](https://github.com/facebookresearch/beanmachine/blob/main/CONTRIBUTING.md)** document. - [ ] I have added tests to cover my changes. - [x] All new and existing tests passed. - [x] The title of my pull request is a short description of the requested changes. Reviewed By: jpchen Differential Revision: D33238045 Pulled By: feynmanliang fbshipit-source-id: 02d1fd6a66921d2894294bfa33f2fe27a6e19b5e
- Loading branch information