Skip to content
This repository has been archived by the owner on Dec 18, 2023. It is now read-only.

Regression tutorials (#1195) #1276

Closed

Conversation

feynmanliang
Copy link
Contributor

Summary:

Motivation

Tutorial improvements for OSS release

Changes proposed

  • Merges robust and ordinary linear regression tutorials
  • Cleans up robust regression to run without errors

Pull Request resolved: #1195

Test Plan:
Manual review

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • The title of my pull request is a short description of the requested changes.

Static Docs Preview: beanmachine
|Full Site|

|Modified Pages|
|docs/tutorials|

Reviewed By: wtaha, jpchen

Differential Revision: D32965258

Pulled By: feynmanliang

fbshipit-source-id: 5416b8bf8d6eb3552b40b604e2a9a08668e715f7

Motivation

Please describe your motivation for the changes. Provide link to any related issues.

Changes proposed

Outline the proposed changes and alternatives considered.

Test Plan

Please provide clear instructions on how the changes were verified. Attach screenshots if applicable.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • The title of my pull request is a short description of the requested changes.

Summary:
### Motivation
Tutorial improvements for OSS release

### Changes proposed
* Merges robust and ordinary linear regression tutorials
* Cleans up robust regression to run without errors

Pull Request resolved: facebookresearch#1195

Test Plan:
Manual review

### Types of changes
- [x] Docs change / refactoring / dependency upgrade
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

### Checklist
- [x] My code follows the code style of this project.
- [x] My change requires a change to the documentation.
- [x] I have updated the documentation accordingly.
- [x] I have read the **[CONTRIBUTING](https://github.com/facebookincubator/BeanMachine/blob/master/CONTRIBUTING.md)** document.
- [ ] I have added tests to cover my changes.
- [ ] All new and existing tests passed.
- [x] The title of my pull request is a short description of the requested changes.

**Static Docs Preview: beanmachine**
|[Full Site](https://our.intern.facebook.com/intern/staticdocs/eph/D32965258/V3/beanmachine/)|

|**Modified Pages**|
|[docs/tutorials](https://our.intern.facebook.com/intern/staticdocs/eph/D32965258/V3/beanmachine/docs/tutorials/)|

Reviewed By: wtaha, jpchen

Differential Revision: D32965258

Pulled By: feynmanliang

fbshipit-source-id: 5416b8bf8d6eb3552b40b604e2a9a08668e715f7
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 15, 2021
@facebook-github-bot
Copy link
Collaborator

@feynmanliang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Collaborator

@feynmanliang has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Collaborator

@wtaha has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants