This repository has been archived by the owner on Dec 18, 2023. It is now read-only.
Upgrade deprecated APIs in PyTorch 1.11 & clean out some legacy codes #1378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D34833587 |
…facebookresearch#1378) Summary: Pull Request resolved: facebookresearch#1378 PyTorch 1.11 was released last Thursday, which introduces a few Deprecation Warnings that were [caught by our CI](https://github.com/facebookresearch/beanmachine/runs/5507917348?check_suite_focus=true). This diff addresses those warnings by updating the relevant function calls. It also caught my attention that some of the warnings come from our legacy inference module, which was kept around when we did the migration just in case "something happens." Now that the new inference has been out for a while, we can begin to clean out the legacy modules. In this diff I still kept some algorithms around because there are still some modules that depends on them -- in theory it should be safe to swap all of them out with the new implementation, though it's probably do that in a separate diff. Differential Revision: D34833587 fbshipit-source-id: 49ec4a344954c16952c9afdcec5ee4ecd5388a46
horizon-blue
force-pushed
the
export-D34833587
branch
from
957fa29
to
2596d2a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D34833587 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
PyTorch 1.11 was released last Thursday, which introduces a few Deprecation Warnings that were caught by our CI. This diff addresses those warnings by updating the relevant function calls.
It also caught my attention that some of the warnings come from our legacy inference module, which was kept around when we did the migration just in case "something happens." Now that the new inference has been out for a while, we can begin to clean out the legacy modules. In this diff I still kept some algorithms around because there are still some modules that depends on them -- in theory it should be safe to swap all of them out with the new implementation, though it's probably do that in a separate diff.
Differential Revision: D34833587