This repository has been archived by the owner on Dec 18, 2023. It is now read-only.
Update static docs to describe NNC #1619
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@feynmanliang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
feynmanliang
added a commit
to feynmanliang/beanmachine
that referenced
this pull request
Aug 25, 2022
…search#1619) Summary: ### Motivation NNC is no longer in experimental. Lets update docs to encourage usage. ### Changes proposed Defaults NNC to true, updates static docs to feature NNC prominently. Pull Request resolved: facebookresearch#1619 Test Plan: GH docs build ### Types of changes - [x] Docs change / refactoring / dependency upgrade - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Breaking change (fix or feature that would cause existing functionality to change) ### Checklist - [x] My code follows the code style of this project. - [x] My change requires a change to the documentation. - [x] I have updated the documentation accordingly. - [x] I have read the **[CONTRIBUTING](https://github.com/facebookresearch/beanmachine/blob/main/CONTRIBUTING.md)** document. - [ ] I have added tests to cover my changes. - [ ] All new and existing tests passed. - [x] The title of my pull request is a short description of the requested changes. Differential Revision: D38956485 Pulled By: feynmanliang fbshipit-source-id: bba8eaabfdec8036638fafeaaa3874b7b4e8fc90
feynmanliang
force-pushed
the
nnc_staticdocs
branch
from
cc5578d
to
527617a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D38956485 |
feynmanliang
added a commit
to feynmanliang/beanmachine
that referenced
this pull request
Aug 26, 2022
…search#1619) Summary: ### Motivation NNC is no longer in experimental. Lets update docs to encourage usage. ### Changes proposed Defaults NNC to true, updates static docs to feature NNC prominently. Pull Request resolved: facebookresearch#1619 Test Plan: GH docs build ### Types of changes - [x] Docs change / refactoring / dependency upgrade - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Breaking change (fix or feature that would cause existing functionality to change) ### Checklist - [x] My code follows the code style of this project. - [x] My change requires a change to the documentation. - [x] I have updated the documentation accordingly. - [x] I have read the **[CONTRIBUTING](https://github.com/facebookresearch/beanmachine/blob/main/CONTRIBUTING.md)** document. - [ ] I have added tests to cover my changes. - [ ] All new and existing tests passed. - [x] The title of my pull request is a short description of the requested changes. Differential Revision: D38956485 Pulled By: feynmanliang fbshipit-source-id: 4486915765f868bb9de05eef6f90bf4b1bdff144
feynmanliang
force-pushed
the
nnc_staticdocs
branch
from
527617a
to
1c86a33
Compare
|
This pull request was exported from Phabricator. Differential Revision: D38956485 |
…search#1619) Summary: ### Motivation NNC is no longer in experimental. Lets update docs to encourage usage. ### Changes proposed Defaults NNC to true, updates static docs to feature NNC prominently. Pull Request resolved: facebookresearch#1619 Test Plan: GH docs build ### Types of changes - [x] Docs change / refactoring / dependency upgrade - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Breaking change (fix or feature that would cause existing functionality to change) ### Checklist - [x] My code follows the code style of this project. - [x] My change requires a change to the documentation. - [x] I have updated the documentation accordingly. - [x] I have read the **[CONTRIBUTING](https://github.com/facebookresearch/beanmachine/blob/main/CONTRIBUTING.md)** document. - [ ] I have added tests to cover my changes. - [ ] All new and existing tests passed. - [x] The title of my pull request is a short description of the requested changes. Differential Revision: D38956485 Pulled By: feynmanliang fbshipit-source-id: 1fca7a8e2ad36a62b19770cc9d446a5f842dec85
|
This pull request was exported from Phabricator. Differential Revision: D38956485 |
feynmanliang
force-pushed
the
nnc_staticdocs
branch
from
1c86a33
to
b41895b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
NNC is no longer in experimental. Lets update docs to encourage usage.
Changes proposed
Defaults NNC to true, updates static docs to feature NNC prominently.
Test Plan
GH docs build
Types of changes
Checklist